Skip to content

[PWGCF] FemtoUniverse Cascade Task -- fixed some histogramming errors#17087

Open
Eloviyo wants to merge 4 commits into
AliceO2Group:masterfrom
Eloviyo:bugFixes
Open

[PWGCF] FemtoUniverse Cascade Task -- fixed some histogramming errors#17087
Eloviyo wants to merge 4 commits into
AliceO2Group:masterfrom
Eloviyo:bugFixes

Conversation

@Eloviyo

@Eloviyo Eloviyo commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pwgcf label Jul 16, 2026
@github-actions github-actions Bot changed the title PWGCF: FemtoUniverse Cascade Task -- fixed some histogramming errors [PWGCF] FemtoUniverse Cascade Task -- fixed some histogramming errors Jul 16, 2026
@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 45 errors, ⚠️ 6 warnings, 🔕 0 disabled

@alibuild

alibuild commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 728a440 at 2026-07-16 15:31:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 134 errors and 252 warnings.'
Found 134 errors and 252 warnings.
++ [[ 134 -gt 0 ]]
++ cat /sw/BUILD/9e9aa00f5248d772a607562fe8473fa35ec967b8/O2Physics-code-check/errors.txt
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:68:8: error: constructor does not initialize these fields: pdgMC, ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:226:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:236:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:237:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:247:16: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:248:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:260:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:260:16: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:272:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:280:64: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:282:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:289:64: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:291:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:300:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:301:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:461:15: error: variable 'posChildTPC' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:461:28: error: variable 'negChildTPC' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:461:41: error: variable 'bachelorTPC' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:461:54: error: variable 'posChildTOF' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:461:67: error: variable 'negChildTOF' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:461:80: error: variable 'bachelorTOF' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:485:15: error: variable 'posChildTPCExt' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:485:31: error: variable 'negChildTPCExt' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:485:47: error: variable 'bachelorTPCExt' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:485:63: error: variable 'posChildTOFExt' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:485:79: error: variable 'negChildTOFExt' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:485:95: error: variable 'bachelorTOFExt' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:529:15: error: variable 'posChildTPC' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:529:28: error: variable 'negChildTPC' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:529:41: error: variable 'bachelorTPC' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:529:54: error: variable 'posChildTOF' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:529:67: error: variable 'negChildTOF' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:529:80: error: variable 'bachelorTOF' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:547:155: error: the parameter 'mcParts' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:556:39: error: narrowing conversion from 'unwrap_t<float>' (aka 'float') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:556:55: error: narrowing conversion from 'unwrap_t<float>' (aka 'float') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:567:15: error: variable 'posChildTPC' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:567:28: error: variable 'negChildTPC' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:567:41: error: variable 'bachelorTPC' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:567:54: error: variable 'posChildTOF' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:567:67: error: variable 'negChildTOF' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:567:80: error: variable 'bachelorTOF' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 467c528 at 2026-07-16 17:41:

## sw/BUILD/O2Physics-latest/log
2026-07-16T17:24:47.302+0200 [24:140226436942400] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-16T17:24:47.302+0200 [24:140226436942400] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-07-16T17:28:17.121+0200 [24:140226436942400] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv6:%5B::1%5D:8980: Failed to connect to remote host: Connection refused]
2026-07-16T17:24:47.695+0200 [25:139868904585792] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-16T17:24:47.695+0200 [25:139868904585792] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-07-16T17:29:14.786+0200 [25:139868904585792] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv6:%5B::1%5D:8980: Failed to connect to remote host: Connection refused]
2026-07-16T17:24:47.670+0200 [23:140327835408960] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-16T17:24:47.670+0200 [23:140327835408960] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-07-16T17:30:00.895+0200 [23:140327835408960] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv6:%5B::1%5D:8980: Failed to connect to remote host: Connection refused]


## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 134 errors and 252 warnings.'
Found 134 errors and 252 warnings.
++ [[ 134 -gt 0 ]]
++ cat /sw/BUILD/fd45d2bae6d46a557d47fa725f7481bb0d980c84/O2Physics-code-check/errors.txt
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:68:8: error: constructor does not initialize these fields: pdgMC, ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:226:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:236:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:237:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:247:16: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:248:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:260:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:260:16: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:272:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:280:64: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:282:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:289:64: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:291:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:300:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:301:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:461:15: error: variable 'posChildTPC' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:461:28: error: variable 'negChildTPC' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:461:41: error: variable 'bachelorTPC' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:461:54: error: variable 'posChildTOF' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:461:67: error: variable 'negChildTOF' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:461:80: error: variable 'bachelorTOF' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:485:15: error: variable 'posChildTPCExt' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:485:31: error: variable 'negChildTPCExt' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:485:47: error: variable 'bachelorTPCExt' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:485:63: error: variable 'posChildTOFExt' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:485:79: error: variable 'negChildTOFExt' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:485:95: error: variable 'bachelorTOFExt' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:529:15: error: variable 'posChildTPC' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:529:28: error: variable 'negChildTPC' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:529:41: error: variable 'bachelorTPC' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@prchakra prchakra Awaiting requested review from prchakra prchakra is a code owner
@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner
@majanik majanik Awaiting requested review from majanik majanik is a code owner
@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner
@dimihayl dimihayl Awaiting requested review from dimihayl dimihayl is a code owner
@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner
@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner
@wrzesaCERN wrzesaCERN Awaiting requested review from wrzesaCERN wrzesaCERN is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Eloviyo @alibuild